Solved Trying to fix default folder icon with batch file and desktop.ini

Bug locker · May 5, 2024

Hey.
I use this tweak in order to change the default order icon. It not works 100% OK.
Depending on the selected view it appears wrong. E.g :

I noticed though, that when a folder contains a desktop.ini then all folders display correctly in all views.

So , i think to solve that problem (i guess there is no better solution) by put my own desktop.ini at all folders that they dont already have one.
I think that will be done with a batch file and i tried with no success. Unfortunately it's not one of the languages I've dealt with.

The algorithm is simple :
Begining from root (C:)
if the folder not contains desktop.ini
then copy C:\desktop.ini to current folder path
I think the main code is something like that but we need the action in a subroutine.

Code:

@echo off
cd\
FOR /R  %%D IN (*) DO (call :subroutine "%%D")


GOTO :eof


:subroutine

Could anyone with batch language knowledge , translate this algorithm to batch code ?
Also , i there is any suggestion to solve the primary problem please tell me.

Thanks.

pseymour · May 5, 2024

This would show you which folders do not have desktop.ini files in them. Just replace the echo command at the end with a copy command. No need for jumping around and subroutines.

for /f "tokens=*" %%a in ('dir C:\ /ad /b /s') do @if not exist "%%a\desktop.ini" echo %%a

Note that that code is for a batch file. If running it from a command prompt, replace the double percent symbols with singles.

Bug locker · May 5, 2024

pseymour said:
This would show you which folders do not have desktop.ini files in them. Just replace the echo command at the end with a copy command. No need for jumping around and subroutines.

for /f "tokens=*" %%a in ('dir C:\ /ad /b /s') do @if not exist "%%a\desktop.ini" echo %%a

Note that that code is for a batch file. If running it from a command prompt, replace the double percent symbols with singles.

I run this batch :

Code:

cd\
for /f "tokens=*" %%a in ('dir C:\ /ad /b /s') do @if not exist "%%a\desktop.ini" echo %%a
pause

But its show only that :

pseymour · May 5, 2024

Did you wait for it to finish? It has to loop through all of the directories and check each one before it displays any output. Your screenshot looks like it hasn't finished yet, because I don't see your pause command.

Bug locker · May 5, 2024

pseymour said:
Did you wait for it to finish? It has to loop through all of the directories and check each one before it displays any output. Your screenshot looks like it hasn't finished yet, because I don't see your pause command.

Nope. It looks like its stopped :

Think that i already i have folders at root (C:) without desktop.ini in. So it will shows the echo.

pseymour · May 5, 2024

It won't do any echos until it's finished looping through the directories. This isn't PowerShell.

Bug locker · May 5, 2024

pseymour said:
It won't do any echos until it's finished looping through the directories. This isn't PowerShell.

It looks you have right. I run this and it takes 1 sec.

Code:

REM @echo off
title fix default folder icon
cd\
for /f "tokens=*" %%a in ('dir C:\users\thana\desktop /ad /b /s') do @if not exist "%%a\desktop.ini" echo %%a
pause

With that export :

So i go to destination issue.

Code:

for /f "tokens=*" %%a in ('dir C:\users\thana\desktop /ad /b /s') do @if not exist "%%a\desktop.ini" copy c:\desktopinitest.ini %%a

Is that correct ? I use other name in order to delete in case of fault results.

pseymour · May 5, 2024

That looks good, except I would wrap that last %%a in quotes, in case the path has spaces in it.

Bug locker · May 5, 2024

pseymour said:
That looks good, except I would wrap that last %%a in quotes, in case the path has spaces in it.

Yep you are right. I already taking errors "incorrect syntax" for that reason.
Thanks.

Bug locker · May 5, 2024

pseymour said:
That looks good, except I would wrap that last %%a in quotes, in case the path has spaces in it.

So the current code is :

Code:

REM @echo off
title fix default folder icon
cd\
for /f "tokens=*" %%a in ('dir C:\users\thana\desktop /ad /b /s') do @if not exist "%%a\desktop.ini" copy C:\desktopinitest.txt "%%a"
pause

But still it gives 2 errors :

pseymour · May 5, 2024

Probably some wonky path or something you don't have access to. You could do multiple commands for each directory like this:

Batch:

for /f "tokens=*" %%a in ('dir %USERPROFILE%\Desktop /ad /b /s') do (
REM first command here
REM second command here
REM etc.
)

So then you maybe have an echo for the first command and the copy command for the second command. The echo would show you which folder is having issues.

Bug locker · May 5, 2024

I run that , and nothing happens except a flashing window for 1 sec :

Code:

@echo off
for /f "tokens=*" %%a in ('dir %USERPROFILE%\Desktop /ad /b /s') do
 (
echo "%%a"
@if not exist "%%a\desktop.ini" copy C:\desktopinitest.txt "%%a"
pause
)

pseymour · May 5, 2024

If you ran it in a command prompt, you'd see that the message is "The syntax of the command is incorrect." Because you moved the ( after do to the next line.

Bug locker · May 6, 2024

pseymour said:
If you ran it in a command prompt, you'd see that the message is "The syntax of the command is incorrect." Because you moved the ( after do to the next line.

Another error:

Current code :

Code:

@echo off
for /f "tokens=*" %%a in ('dir %USERPROFILE%\Desktop /ad /b /s') do  (
echo "%%a"
@if not exist "%%a\desktop.ini" copy "C:\Users\thana\Desktop\Recent_pcts\desktop.ini" "%%a"
pause
)

Note : the C:\Users\thana\Desktop\Recent_pcts\desktop.ini has the original attributes System , Archived , Hidden.

Bug locker · May 6, 2024

pseymour said:
If you ran it in a command prompt, you'd see that the message is "The syntax of the command is incorrect." Because you moved the ( after do to the next line.

So the problem was the attributes. I put at root a desktop.ini with cleared attributes.
At command prompt the copy works. The current code , not works , only a flashing window :

Code:

@echo off
for /f "tokens=*" %%a in ('dir %USERPROFILE%\Desktop /ad /b /s') do  (
echo "%%a"
@if not exist "%%a\desktop.ini"
copy "C:\desktop.ini" "%%a"
attrib +s +h "%%a\desktop.ini"
 pause
)

And command prompt :

EDIT : I put () at commands and it looks it works :

Code:

@if not exist "%%a\desktop.ini" (
copy "C:\desktop.ini" "%%a"
attrib +s +h "%%a\desktop.ini" )

Bug locker · May 6, 2024

pseymour said:
If you ran it in a command prompt, you'd see that the message is "The syntax of the command is incorrect." Because you moved the ( after do to the next line.

So it works , but it has one bug. When the name of the folder contains space ( ) ,
it cant read the name and gives the error :

Also i cant underrstand why it shows that path (C:\users\thana\Desktop).

I tried to put "" at %%a , but not works.
Current code :

Code:

@echo off
for /f "tokens=*" %%a in ('dir %USERPROFILE%\Εφαρμογές /ad /b /s') do  (
echo "%%a"
@if not exist "%%a\desktop.ini" (
copy "C:\desktop.ini" "%%a"
attrib +s +h "%%a\desktop.ini" )
 pause
)

EDIT : isn't the cause the space but something else :

FreeBooter · May 6, 2024

With this batch script, you can change the Windows 10 or Windows 11 folder icons. You need a folder icon placed next to the batch script and named the folder icon as Blue Folder.ico

Code:

::  Change Windows 10 or Windows 11 folder icons


@Echo Off

Cls & Color 0E

(Net session >nul 2>&1)||(PowerShell start """%~0""" -verb RunAs & Exit /B)


:_CHOICE

Cls & Mode CON  LINES=11 COLS=60 & Color 0E & Title Created By FreeBooter
Echo.
Echo.
Echo.
Echo        1 - Change Windows Folder Icon
Echo.       
Echo        2 - Restore Default Folder Icon
Echo.


Set /p input=:^>

If Not %input%==1 (Goto :_Ex) Else (Goto :_Change)

:_Ex
If Not %input%==2  (Goto :_CHOICE) Else (Goto :_Restore)




:_Change

Cd /d %~dp0

Md c:\blue_folder

Move /Y "Blue Folder.ico"  c:\blue_folder


Reg.exe add "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Icons" /v "3" /t REG_SZ /d "c:\blue_folder\Blue Folder.ico" /f

Goto :RestartEx






:_Restore



Reg.exe delete "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Icons" /v "3" /f







:RestartEx

Taskkill /im Explorer.exe /f

Start Explorer.exe

Exit

Bug locker · May 6, 2024

Finally it worked. Protected system folders and folders that already have them own icon folder are excluded.
Also so
The code is:

Code:

cls
cd\
@echo off
for /f "tokens=*" %%a in ('dir c: /ad /b /s') do  (
echo "%%a"
@if not exist "%%a\desktop.ini" (
copy "C:\desktop.ini" "%%a"
attrib +s +h "%%a\desktop.ini" )
)
pause

Thanks to pseymor.