Advanced network settings for home file sharing

After much pain, I got file sharing between my home Win 11 Home 23H2 and Pro 23H2 but I had to set the public network and all networks on like:



My worry it that seems like I'm sharing to the entire world. Is this right? Is this in no way accessible outside my little 2 home computers behind a router on home fiber internet?

I tried a LOT of things before landing on this... including:
Control Panel->Programs->Turn Windows features on or off->SMB 1.0/CIFS File Sharing Support ON (ignoring security weaknesses....???)

Maybe my question(s) is , now that it works, what should I turn off?

You're not sharing to the entire world, if you're behind a router. If you live in the US (and maybe other places), your ISP would probably block the ports for file sharing anyway. They've been doing this for a long time, because it's dangerous.

You should only use SMB1 if you absolutely have to, but again, you're behind a router, so it's probably fine. It's just old and unsafe.

Well, that's what I kind of thought so thanks but I had to confirm and ask. I'll try turning off SMB1

Better to ask if you're unsure, than to leave yourself exposed.

No you're not sharing with the Internet. NAT on the router doesn't allow for that unless you specifically set up port forwarding on the router. I would disable SMBv1 it's only needed for very old operating systems

Is there an echo in here?

Echo!